Fixes #3564: Fixed the bug that primary key columns should not take default values from schema

framework/CHANGELOG.md

@@ -30,6 +30,7 @@ Yii Framework 2 Change Log
 - Bug #3458: Fixed the bug that the image rendered by `CaptchaAction` was using a wrong content type (MDMunir, qiangxue)
 - Bug #3522: Fixed BaseFileHelper::normalizePath to allow a (.) for the current path. (skotos)
 - Bug #3548: Fixed the bug that X-Rate-Limit-Remaining header is always zero when using RateLimiter (qiangxue)
+- Bug #3564: Fixed the bug that primary key columns should not take default values from schema (qiangxue)
 - Bug #3567: Fixed the bug that smallint was treated as string for PostgreSQL (qiangxue)
 - Bug: Fixed inconsistent return of `\yii\console\Application::runAction()` (samdark)
 - Enh #2264: `CookieCollection::has()` will return false for expired or removed cookies (qiangxue)

framework/db/cubrid/Schema.php

@@ -227,6 +227,10 @@ class Schema extends \yii\db\Schema
 
         $column->phpType = $this->getColumnPhpType($column);
 
+        if ($column->isPrimaryKey) {
+            return $column;
+        }
+
         if ($column->type === 'timestamp' && $info['Default'] === 'CURRENT_TIMESTAMP' ||
             $column->type === 'datetime' && $info['Default'] === 'SYS_DATETIME' ||
             $column->type === 'date' && $info['Default'] === 'SYS_DATE' ||

framework/db/mssql/Schema.php

@@ -221,7 +221,7 @@ class Schema extends \yii\db\Schema
         if ($info['column_default'] == '(NULL)') {
             $info['column_default'] = null;
         }
-        if ($column->type !== 'timestamp' || $info['column_default'] !== 'CURRENT_TIMESTAMP') {
+        if (!$column->isPrimaryKey && ($column->type !== 'timestamp' || $info['column_default'] !== 'CURRENT_TIMESTAMP')) {
             $column->defaultValue = $column->typecast($info['column_default']);
         }
 

framework/db/mysql/Schema.php

@@ -168,7 +168,7 @@ class Schema extends \yii\db\Schema
 
         $column->phpType = $this->getColumnPhpType($column);
 
-        if ($column->type !== 'timestamp' || $info['Default'] !== 'CURRENT_TIMESTAMP') {
+        if (!$column->isPrimaryKey && ($column->type !== 'timestamp' || $info['Default'] !== 'CURRENT_TIMESTAMP')) {
             $column->defaultValue = $column->typecast($info['Default']);
         }
 

framework/db/oci/Schema.php

@@ -170,11 +170,13 @@ EOD;
         $this->extractColumnType($c, $column['DATA_TYPE']);
         $this->extractColumnSize($c, $column['DATA_TYPE']);
 
+        if (!$column->isPrimaryKey) {
             if (stripos($column['DATA_DEFAULT'], 'timestamp') !== false) {
                 $c->defaultValue = null;
             } else {
                 $c->defaultValue = $c->typecast($column['DATA_DEFAULT']);
             }
+        }
 
         return $c;
     }

framework/db/pgsql/Schema.php

@@ -367,14 +367,12 @@ SQL;
         foreach ($columns as $column) {
             $column = $this->loadColumnSchema($column);
             $table->columns[$column->name] = $column;
-            if ($column->isPrimaryKey === true) {
+            if ($column->isPrimaryKey) {
                 $table->primaryKey[] = $column->name;
                 if ($table->sequenceName === null && preg_match("/nextval\\('\"?\\w+\"?\.?\"?\\w+\"?'(::regclass)?\\)/", $column->defaultValue) === 1) {
                     $table->sequenceName = preg_replace(['/nextval/', '/::/', '/regclass/', '/\'\)/', '/\(\'/'], '', $column->defaultValue);
                 }
-            }
-
-            if ($column->defaultValue) {
+            } elseif ($column->defaultValue) {
                 if (preg_match("/^'(.*?)'::/", $column->defaultValue, $matches) || preg_match("/^(.*?)::/", $column->defaultValue, $matches)) {
                     $column->defaultValue = $matches[1];
                 }

framework/db/sqlite/Schema.php

@@ -238,12 +238,14 @@ class Schema extends \yii\db\Schema
         }
         $column->phpType = $this->getColumnPhpType($column);
 
+        if (!$column->isPrimaryKey) {
             $value = trim($info['dflt_value'], "'\"");
             if ($column->type === 'string') {
                 $column->defaultValue = $value;
             } else {
                 $column->defaultValue = $column->typecast(strcasecmp($value, 'null') ? $value : null);
             }
+        }
 
         return $column;
     }