Fixes #4371: Active form client validation wasn't working in case of two models…

Fixes #4371: Active form client validation wasn't working in case of two models having same named fields When rendering multiple models in the same ActiveForm if any of the field names in the two models is the same then the corresponding attribute in the yiiActiveForm object in yiiActiveForm.js (ie $('form').data('yiiActiveForm').attributes) of the first rendered model is overwritten by the attribute of the last model causing the client-side validation for the overwritten field not to run at all. Example: given two models Car and Owner with attributes {make, age} and {name, age} then if the Car is rendered first its age attribute will not have any client validation.

Fixes #4371: Active form client validation wasn't working in case of two models…
b7cad9df · abrahamy · Alexander Makarov · ba606d06 · b7cad9df · b7cad9df
Commit b7cad9df authored Jul 19, 2014 by abrahamy Committed by Alexander Makarov Aug 12, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

CHANGELOG.md framework/CHANGELOG.md +1 -0

ActiveField.php framework/widgets/ActiveField.php +1 -1

No files found.
--- a/framework/CHANGELOG.md
+++ b/framework/CHANGELOG.md
@@ -69,6 +69,7 @@ Yii Framework 2 Change Log
 - Bug #4241: `yii\widgets\Pjax` was incorrectly setting container id (mitalcoi)
 - Bug #4276: Added check for UPLOAD_ERR_NO_FILE in `yii\web\UploadedFile` and return null if no file was uploaded (OmgDef)
 - Bug #4342: mssql (dblib) driver does not support getting attributes (tof06)
+- Bug #4371: Active form client validation wasn't working in case of two models having same named fields (abrahamy)
 - Bug #4409: Upper case letters in subdirectory prefixes of controller IDs were not properly handled (qiangxue)
 - Bug #4412: Formatter used SI Prefixes for base 1024, now uses binary prefixes (kmindi)
 - Bug #4427: Formatter could do one division too much (kmindi)

--- a/framework/widgets/ActiveField.php
+++ b/framework/widgets/ActiveField.php
@@ -195,7 +195,7 @@ class ActiveField extends Component
    {
        $clientOptions = $this->getClientOptions();
        if (!empty($clientOptions)) {
-            $this->form->attributes[$this->attribute] = $clientOptions;
+            $this->form->attributes[Html::getInputId($this->model, $this->attribute)] = $clientOptions;
        }

        $inputID = Html::getInputId($this->model, $this->attribute);