url wip

docs/api/db/ActiveRecord.md

@@ -300,7 +300,7 @@ foreach ($customers as $customer) {
 ~~~
 
 How many SQL queries will be performed in the above code, assuming there are more than 100 customers in
-the database? 101! The first SQL query brings back 100 customers. Then for each customer, another SQL query
+the database? 101! The first SQL query brings back 100 customers. Then for each customer, a SQL query
 is performed to bring back the customer's orders.
 
 To solve the above performance problem, you can use the so-called *eager loading* by calling [[ActiveQuery::with()]]:
@@ -318,7 +318,7 @@ foreach ($customers as $customer) {
 }
 ~~~
 
-As you can see, only two SQL queries were needed for the same task.
+As you can see, only two SQL queries are needed for the same task.
 
 
 Sometimes, you may want to customize the relational queries on the fly. It can be

framework/web/UrlManager.php

@@ -98,24 +98,50 @@ class UrlManager extends Component
 	 */
 	protected function processRules()
 	{
+		foreach ($this->rules as $i => $rule) {
+			if (!isset($rule['class'])) {
+				$rule['class'] = 'yii\web\UrlRule';
+			}
+			$this->rules[$i] = \Yii::createObject($rule);
+		}
 	}
 
 	/**
 	 * Parses the user request.
-	 * @param HttpRequest $request the request application component
+	 * @param Request $request the request application component
 	 * @return string the route (controllerID/actionID) and perhaps GET parameters in path format.
 	 */
 	public function parseUrl($request)
 	{
-		if (isset($_GET[$this->routeVar])) {
-			return $_GET[$this->routeVar];
-		} else {
-			return '';
+	}
+
+	public function createUrl($route, $params = array())
+	{
+		$anchor = isset($params['#']) ? '#' . $params['#'] : '';
+		unset($anchor['#']);
+
+		/** @var $rule UrlRule */
+		foreach ($this->rules as $rule) {
+			if (($url = $rule->createUrl($route, $params)) !== false) {
+				return $this->getBaseUrl() . $url . $anchor;
+			}
 		}
+
+		if ($params !== array()) {
+			$route .= '?' . http_build_query($params);
+		}
+		return $this->getBaseUrl() . '/' . $route . $anchor;
 	}
 
-	public function createUrl($route, $params = array(), $ampersand = '&')
+	private $_baseUrl;
+
+	public function getBaseUrl()
 	{
+		return $this->_baseUrl;
+	}
 
+	public function setBaseUrl($value)
+	{
+		$this->_baseUrl = trim($value, '/');
 	}
 }

framework/web/UrlRule.php

@@ -14,9 +14,15 @@ use yii\base\Object;
 /**
  * UrlManager manages the URLs of Yii applications.
  * array(
- *     'pattern' => 'post/<id:\d+>',
+ *     'pattern' => 'post/<page:\d+>',
  *     'route' => 'post/view',
- *     'params' => array('id' => 1),
+ *     'defaults' => array('page' => 1),
+ * )
+ *
+ * array(
+ *     'pattern' => 'about',
+ *     'route' => 'site/page',
+ *     'defaults' => array('view' => 'about'),
  * )
  *
  * @author Qiang Xue <qiang.xue@gmail.com>
@@ -29,22 +35,128 @@ class UrlRule extends Object
 	 */
 	public $pattern;
 	/**
+	 * @var string the route to the controller action
+	 */
+	public $route;
+	/**
 	 * @var array the default GET parameters (name=>value) that this rule provides.
 	 * When this rule is used to parse the incoming request, the values declared in this property
 	 * will be injected into $_GET.
 	 */
-	public $params = array();
-	/**
-	 * @var string the route to the controller action
-	 */
-	public $route;
+	public $defaults = array();
+
+	protected $paramRules = array();
+	protected $routeRule;
+	protected $template;
+	protected $routeParams = array();
+
+	public function init()
+	{
+		$this->pattern = trim($this->pattern, '/');
+		if ($this->pattern === '') {
+			$this->template = '';
+			$this->pattern = '#^$#u';
+			return;
+		} else {
+			$this->pattern = '/' . $this->pattern . '/';
+		}
+
+		$this->route = trim($this->route, '/');
+		if (strpos($this->route, '<') !== false && preg_match_all('/<(\w+)>/', $this->route, $matches)) {
+			foreach ($matches[1] as $name) {
+				$this->routeParams[$name] = "<$name>";
+			}
+		}
+
+		$tr = $tr2 = array();
+		if (preg_match_all('/<(\w+):?([^>]+)?>/', $this->pattern, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER)) {
+			foreach ($matches as $match) {
+				$name = $match[1][0];
+				$pattern = isset($match[2][0]) ? $match[2][0] : '[^\/]+';
+				if (isset($this->defaults[$name])) {
+					$length = strlen($match[0][0]);
+					$offset = $match[0][1];
+					if ($this->pattern[$offset - 1] === '/' && $this->pattern[$offset + $length] === '/') {
+						$tr["<$name>"] = "(?P<$name>(?:/$pattern)?)";
+					} else {
+						$tr["<$name>"] = "(?P<$name>(?:$pattern)?)";
+					}
+				} else {
+					$tr["<$name>"] = "(?P<$name>$pattern)";
+				}
+				if (isset($this->routeParams[$name])) {
+					$tr2["<$name>"] = "(?P<$name>$pattern)";
+				} else {
+					$this->paramRules[$name] = $pattern === '[^\/]+' ? '' : "#^$pattern$#";
+				}
+			}
+		}
+
+		$this->template = preg_replace('/<(\w+):?([^>]+)?>/', '<$1>', $this->pattern);
+		$this->pattern = '#^' . strtr($this->template, $tr) . '$#u';
 
-	public function createUrl($route, $params, $ampersand)
+		if ($this->routeParams !== array()) {
+			$this->routeRule = '#^' . strtr($this->route, $tr2) . '$#u';
+		}
+	}
+
+	public function parseUrl($pathInfo)
 	{
 
 	}
 
-	public function parse($path)
+	public function createUrl($route, $params)
+	{
+		$tr = array();
+
+		// match the route part first
+		if ($route !== $this->route) {
+			if ($this->routeRule !== null && preg_match($this->routeRule, $route, $matches)) {
+				foreach ($this->routeParams as $key => $name) {
+					$tr[$name] = $matches[$key];
+				}
+			} else {
+				return false;
+			}
+		}
+
+		// match default params
+		// if a default param is not in the route pattern, its value must also be matched
+		foreach ($this->defaults as $name => $value) {
+			if (!isset($params[$name])) {
+				return false;
+			} elseif (strcmp($params[$name], $value) === 0) { // strcmp will do string conversion automatically
+				unset($params[$name]);
+				if (isset($this->paramRules[$name])) {
+					$tr["<$name>"] = '';
+					$tr["/<$name>/"] = '/';
+				}
+			} elseif (!isset($this->paramRules[$name])) {
+				return false;
+			}
+		}
+
+		// match params in the pattern
+		foreach ($this->paramRules as $name => $rule) {
+			if (isset($params[$name]) && ($rule === '' || preg_match($rule, $params[$name]))) {
+				$tr["<$name>"] = urlencode($params[$name]);
+				unset($params[$name]);
+			} elseif (!isset($this->defaults[$name]) || isset($params[$name])) {
+				return false;
+			}
+		}
+
+		$url = trim(strtr($this->template, $tr), '/');
+		if (strpos($url, '//') !== false) {
+			$url = preg_replace('#/+#', '/', $url);
+		}
+		if ($params !== array()) {
+			$url .= '?' . http_build_query($params);
+		}
+		return $url;
+	}
+
+	public function parse($pathInfo)
 	{
 		$route = '';
 		$params = array();

tests/unit/framework/web/UrlManagerTest.php

+<?php
+namespace yiiunit\framework\web;
+
+class UrlManagerTest extends \yiiunit\TestCase
+{
+
+}