Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
Y
yii2
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Rotua Panjaitan
yii2
Commits
cfc57c20
Commit
cfc57c20
authored
Oct 23, 2013
by
Carsten Brandt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow ITU message format in validator messages
fixes #991
parent
752037d9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
60 additions
and
19 deletions
+60
-19
I18N.php
framework/yii/i18n/I18N.php
+41
-0
BooleanValidator.php
framework/yii/validators/BooleanValidator.php
+2
-2
CompareValidator.php
framework/yii/validators/CompareValidator.php
+2
-2
FileValidator.php
framework/yii/validators/FileValidator.php
+5
-5
NumberValidator.php
framework/yii/validators/NumberValidator.php
+2
-2
RequiredValidator.php
framework/yii/validators/RequiredValidator.php
+1
-1
StringValidator.php
framework/yii/validators/StringValidator.php
+3
-3
Validator.php
framework/yii/validators/Validator.php
+3
-3
ValidatorTest.php
tests/unit/framework/validators/ValidatorTest.php
+1
-1
No files found.
framework/yii/i18n/I18N.php
View file @
cfc57c20
...
...
@@ -63,6 +63,9 @@ class I18N extends Component
/**
* Translates a message to the specified language.
*
* After translation the message will be parsed using [[MessageFormatter]] if it contains
* ITU message format and `$params` are not empty.
*
* @param string $category the message category.
* @param string $message the message to be translated.
* @param array $params the parameters that will be used to replace the corresponding placeholders in the message.
...
...
@@ -102,6 +105,44 @@ class I18N extends Component
}
/**
* Formats a message using using [[MessageFormatter]].
*
* @param string $message the message to be formatted.
* @param array $params the parameters that will be used to replace the corresponding placeholders in the message.
* @param string $language the language code (e.g. `en_US`, `en`).
* @return string the formatted message.
*/
public
function
format
(
$message
,
$params
,
$language
)
{
$params
=
(
array
)
$params
;
if
(
$params
===
[])
{
return
$message
;
}
if
(
preg_match
(
'~{\s*[\d\w]+\s*,~u'
,
$message
))
{
$formatter
=
new
MessageFormatter
(
$language
,
$message
);
if
(
$formatter
===
null
)
{
Yii
::
warning
(
"Message for
$language
is invalid:
$message
."
);
return
$message
;
}
$result
=
$formatter
->
format
(
$params
);
if
(
$result
===
false
)
{
$errorMessage
=
$formatter
->
getErrorMessage
();
Yii
::
warning
(
"Formatting message for
$language
failed with error:
$errorMessage
. Message is:
$message
."
);
return
$message
;
}
else
{
return
$result
;
}
}
$p
=
[];
foreach
(
$params
as
$name
=>
$value
)
{
$p
[
'{'
.
$name
.
'}'
]
=
$value
;
}
return
strtr
(
$message
,
$p
);
}
/**
* Returns the message source for the given category.
* @param string $category the category name.
* @return MessageSource the message source for the given category.
...
...
framework/yii/validators/BooleanValidator.php
View file @
cfc57c20
...
...
@@ -58,8 +58,8 @@ class BooleanValidator extends Validator
$value
=
$object
->
$attribute
;
if
(
!
$this
->
validateValue
(
$value
))
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
message
,
[
'
{true}
'
=>
$this
->
trueValue
,
'
{false}
'
=>
$this
->
falseValue
,
'
true
'
=>
$this
->
trueValue
,
'
false
'
=>
$this
->
falseValue
,
]);
}
}
...
...
framework/yii/validators/CompareValidator.php
View file @
cfc57c20
...
...
@@ -143,8 +143,8 @@ class CompareValidator extends Validator
}
if
(
!
$valid
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
message
,
[
'
{compareAttribute}
'
=>
$compareLabel
,
'
{compareValue}
'
=>
$compareValue
,
'
compareAttribute
'
=>
$compareLabel
,
'
compareValue
'
=>
$compareValue
,
]);
}
}
...
...
framework/yii/validators/FileValidator.php
View file @
cfc57c20
...
...
@@ -144,7 +144,7 @@ class FileValidator extends Validator
$this
->
addError
(
$object
,
$attribute
,
$this
->
uploadRequired
);
}
if
(
count
(
$files
)
>
$this
->
maxFiles
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooMany
,
[
'
{attribute}'
=>
$attribute
,
'{limit}
'
=>
$this
->
maxFiles
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooMany
,
[
'
limit
'
=>
$this
->
maxFiles
]);
}
else
{
foreach
(
$files
as
$file
)
{
$this
->
validateFile
(
$object
,
$attribute
,
$file
);
...
...
@@ -171,18 +171,18 @@ class FileValidator extends Validator
switch
(
$file
->
error
)
{
case
UPLOAD_ERR_OK
:
if
(
$this
->
maxSize
!==
null
&&
$file
->
size
>
$this
->
maxSize
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooBig
,
[
'
{file}'
=>
$file
->
name
,
'{limit}
'
=>
$this
->
getSizeLimit
()]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooBig
,
[
'
file'
=>
$file
->
name
,
'limit
'
=>
$this
->
getSizeLimit
()]);
}
if
(
$this
->
minSize
!==
null
&&
$file
->
size
<
$this
->
minSize
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooSmall
,
[
'
{file}'
=>
$file
->
name
,
'{limit}
'
=>
$this
->
minSize
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooSmall
,
[
'
file'
=>
$file
->
name
,
'limit
'
=>
$this
->
minSize
]);
}
if
(
!
empty
(
$this
->
types
)
&&
!
in_array
(
strtolower
(
pathinfo
(
$file
->
name
,
PATHINFO_EXTENSION
)),
$this
->
types
,
true
))
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
wrongType
,
[
'
{file}'
=>
$file
->
name
,
'{extensions}
'
=>
implode
(
', '
,
$this
->
types
)]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
wrongType
,
[
'
file'
=>
$file
->
name
,
'extensions
'
=>
implode
(
', '
,
$this
->
types
)]);
}
break
;
case
UPLOAD_ERR_INI_SIZE
:
case
UPLOAD_ERR_FORM_SIZE
:
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooBig
,
[
'
{file}'
=>
$file
->
name
,
'{limit}
'
=>
$this
->
getSizeLimit
()]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooBig
,
[
'
file'
=>
$file
->
name
,
'limit
'
=>
$this
->
getSizeLimit
()]);
break
;
case
UPLOAD_ERR_PARTIAL
:
$this
->
addError
(
$object
,
$attribute
,
$this
->
message
);
...
...
framework/yii/validators/NumberValidator.php
View file @
cfc57c20
...
...
@@ -91,10 +91,10 @@ class NumberValidator extends Validator
$this
->
addError
(
$object
,
$attribute
,
$this
->
message
);
}
if
(
$this
->
min
!==
null
&&
$value
<
$this
->
min
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooSmall
,
[
'
{min}
'
=>
$this
->
min
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooSmall
,
[
'
min
'
=>
$this
->
min
]);
}
if
(
$this
->
max
!==
null
&&
$value
>
$this
->
max
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooBig
,
[
'
{max}
'
=>
$this
->
max
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooBig
,
[
'
max
'
=>
$this
->
max
]);
}
}
...
...
framework/yii/validators/RequiredValidator.php
View file @
cfc57c20
...
...
@@ -75,7 +75,7 @@ class RequiredValidator extends Validator
$this
->
addError
(
$object
,
$attribute
,
$this
->
message
);
}
else
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
message
,
[
'
{requiredValue}
'
=>
$this
->
requiredValue
,
'
requiredValue
'
=>
$this
->
requiredValue
,
]);
}
}
...
...
framework/yii/validators/StringValidator.php
View file @
cfc57c20
...
...
@@ -112,13 +112,13 @@ class StringValidator extends Validator
$length
=
mb_strlen
(
$value
,
$this
->
encoding
);
if
(
$this
->
min
!==
null
&&
$length
<
$this
->
min
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooShort
,
[
'
{min}
'
=>
$this
->
min
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooShort
,
[
'
min
'
=>
$this
->
min
]);
}
if
(
$this
->
max
!==
null
&&
$length
>
$this
->
max
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooLong
,
[
'
{max}
'
=>
$this
->
max
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
tooLong
,
[
'
max
'
=>
$this
->
max
]);
}
if
(
$this
->
length
!==
null
&&
$length
!==
$this
->
length
)
{
$this
->
addError
(
$object
,
$attribute
,
$this
->
notEqual
,
[
'
{length}
'
=>
$this
->
length
]);
$this
->
addError
(
$object
,
$attribute
,
$this
->
notEqual
,
[
'
length
'
=>
$this
->
length
]);
}
}
...
...
framework/yii/validators/Validator.php
View file @
cfc57c20
...
...
@@ -251,9 +251,9 @@ abstract class Validator extends Component
public
function
addError
(
$object
,
$attribute
,
$message
,
$params
=
[])
{
$value
=
$object
->
$attribute
;
$params
[
'
{attribute}
'
]
=
$object
->
getAttributeLabel
(
$attribute
);
$params
[
'
{value}
'
]
=
is_array
(
$value
)
?
'array()'
:
$value
;
$object
->
addError
(
$attribute
,
strtr
(
$message
,
$params
));
$params
[
'
attribute
'
]
=
$object
->
getAttributeLabel
(
$attribute
);
$params
[
'
value
'
]
=
is_array
(
$value
)
?
'array()'
:
$value
;
$object
->
addError
(
$attribute
,
Yii
::
$app
->
getI18n
()
->
format
(
$message
,
$params
,
Yii
::
$app
->
language
));
}
/**
...
...
tests/unit/framework/validators/ValidatorTest.php
View file @
cfc57c20
...
...
@@ -220,7 +220,7 @@ class ValidatorTest extends TestCase
$errors
=
$m
->
getErrors
(
'attr_msg_val'
);
$this
->
assertEquals
(
'attr_msg_val::array()'
,
$errors
[
0
]);
$m
=
$this
->
getTestModel
([
'attr_msg_val'
=>
'abc'
]);
$val
->
addError
(
$m
,
'attr_msg_val'
,
'{attribute}::{value}::{param}'
,
[
'
{param}
'
=>
'param_value'
]);
$val
->
addError
(
$m
,
'attr_msg_val'
,
'{attribute}::{value}::{param}'
,
[
'
param
'
=>
'param_value'
]);
$errors
=
$m
->
getErrors
(
'attr_msg_val'
);
$this
->
assertEquals
(
'attr_msg_val::abc::param_value'
,
$errors
[
0
]);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment